| Description | Hi Willin
When TJ karaoke app is executed, the following Error Logs are Observed
..
04-17 15:06:07.965 3456 8687 E ringbuffer: ring_buffer_write, Buffer malloc fail!
04-17 15:06:07.986 3456 8687 E ringbuffer: ring_buffer_write, Buffer malloc fail!
..
When I checked the code
STB is using the record_ringbuffer without initializing it ,
So Error Logs are Observed
Code is
hardware/amlogic/audio/audio_hal/audio_hw.c
10824 static int create_patch_l(struct audio_hw_device *dev,
10825 audio_devices_t input,
10826 audio_devices_t output __unused)
10827 {
..
10878 if (patch->out_format == AUDIO_FORMAT_PCM_16_BIT) {
10879 ret = ring_buffer_init(&patch->aml_ringbuffer, 2 * 2 * play_buffer_size * PATCH_PERIOD_COUNT);
10880 if (input == AUDIO_DEVICE_IN_BUILTIN_MIC && output == OUTPORT_HDMI)
10881 ret = ring_buffer_init(&record_ringbuffer, 2 * 2 * play_buffer_size * PATCH_PERIOD_COUNT); <=== This line is not running ,
10882 } else
10883 ret = ring_buffer_init(&patch->aml_ringbuffer, 2 * 4 * play_buffer_size * PATCH_PERIOD_COUNT);
10529 void *audio_patch_input_threadloop(void *data)
10530 {
10531 struct aml_audio_patch *patch = (struct aml_audio_patch *)data;
10532 struct audio_hw_device *dev = patch->dev;
10533 struct aml_audio_device *aml_dev = (struct aml_audio_device *) dev;
10534 ring_buffer_t *ringbuffer = & (patch->aml_ringbuffer);
10535 ring_buffer_t {}ringbuffer_rec{} = &record_ringbuffer{*};
..
10633 do {
10634 if (get_buffer_write_space(ringbuffer) >= bytes_avail) {
10635 retry = 0;
10636 if (aml_dev->in_device & AUDIO_DEVICE_IN_BUILTIN_MIC) {
10637 ret = ring_buffer_write(ringbuffer_rec, <== error logs are observed using the ringbuffer_rec.
10638 (unsigned char*)patch->in_buf,
10639 bytes_avail, COVER_WRITE);
10640 }
10641 ret = ring_buffer_write(ringbuffer,
10642 (unsigned char*)patch->in_buf,
10643 bytes_avail, UNCOVER_WRITE);
The record_ringbuffer code is added by FXN (Peter)
Please review the error log and resolve it
Thank you
YK.Jung |
|---|
.png)
